Re: [PATCH v7 11/17] drm/vkms: Remove useless drm_rotation_simplify

[Louis Chauvet]

Le 16/05/24 - 07:43, Maíra Canal a écrit :
> Hi Louis,
> 
> On 5/13/24 04:50, Louis Chauvet wrote:
> > As all the rotation are now supported by VKMS, this simplification does
> > not make sense anymore, so remove it.
> > 
> > Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> 
> I'd like to push all commits up to this point to drm-misc-next. Do you
> see a problem with it? Reason: I'd like Melissa to take a look at the
> YUV patches and patches 1 to 11 fix several composition errors.
> 
> Let me know your thoughts about it.

Hi,

This version is missing performance numbers and one fix from Pekka, so 
please don't merge v7.

I will push a v8 today (if I have the time to fetch all the performance 
numbers), with the performance numbers and the fix.

Thanks,
Louis Chauvet

> Best Regards,
> - Maíra
> 
> > ---
> >   drivers/gpu/drm/vkms/vkms_plane.c | 7 +------
> >   1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> > index 8875bed76410..5a028ee96c91 100644
> > --- a/drivers/gpu/drm/vkms/vkms_plane.c
> > +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> > @@ -115,12 +115,7 @@ static void vkms_plane_atomic_update(struct drm_plane *plane,
> >   	frame_info->fb = fb;
> >   	memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map));
> >   	drm_framebuffer_get(frame_info->fb);
> > -	frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 |
> > -									  DRM_MODE_ROTATE_90 |
> > -									  DRM_MODE_ROTATE_270 |
> > -									  DRM_MODE_REFLECT_X |
> > -									  DRM_MODE_REFLECT_Y);
> > -
> > +	frame_info->rotation = new_state->rotation;
> >   
> >   	vkms_plane_state->pixel_read_line = get_pixel_read_line_function(fmt);
> >   }
> > 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com