Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

[Neil Armstrong]

On 16/05/2024 13:06, Aradhya Bhatia wrote:
> Hi Liu,
>
> Thanks for reviewing the patch.
>
> On 16/05/24 07:49, Liu Ying wrote:
> > On 5/15/24 17:51, Aradhya Bhatia wrote:
> > > Add the Microtips Technology USA's MF-101HIEBCAF0 10.1"[0] panel,
> > > MF-103HIEB0GA0 10.25"[1] panel, and Lincoln Technology Solutions'
> > > LCD185-101CT 10.1"[2] panel.
> > >
> > > Thes are all dual-lvds panels.
> > >
> > > Panel Links:
> > > [0]: https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2588/13-101HIEBCAF0-S_V1.1_20221104.pdf
> > > [1]: https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf
> >
> > This one mentions some controls in '3. PIN DESCRIPTION' which
> > don't comply with this binding, like RL, TB, STBYB and RESET.
> > Note this binding only allows compatible, ports, backlight,
> > enable-gpios and power-supply properties, nothing more.
>
> Maybe the internal module _can_ support these control options but the
> actual panel hardware does not expose any of these controls on its
> connector pin-out, and hence has no possibility for additional SW
> control. Even for the usage, the device-tree node for the panel only has
> "compatible" and "ports" properties defined.
>
> The panel is being used within the confines of a simple panel.

If somehow some modules with those panels would need more control lines,
we'll simply move them out of simple panel bindings & drivers if
required.

Those are perfectly fine as is, we don't want useless description and dead code.

Neil

> Regards
> Aradhya
>
> > > [2]: https://lincolntechsolutions.com/wp-content/uploads/2023/04/LCD185-101CTL1ARNTT_DS_R1.3.pdf
> > >
> > > Signed-off-by: Aradhya Bhatia <a-bhatia1@xxxxxx>
> > > ---
> > >   .../display/panel/panel-simple-lvds-dual-ports.yaml         | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > > index 716ece5f3978..e78160d1aa24 100644
> > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > > @@ -41,6 +41,12 @@ properties:
> > >         - auo,g190ean01
> > >           # Kaohsiung Opto-Electronics Inc. 10.1" WUXGA (1920 x 1200) LVDS TFT LCD panel
> > >         - koe,tx26d202vm0bwa
> > > +        # Lincoln Technology Solutions, LCD185-101CT 10.1" TFT 1920x1200
> > > +      - lincolntech,lcd185-101ct
> > > +        # Microtips Technology MF-101HIEBCAF0 10.1" WUXGA (1920x1200) TFT LCD panel
> > > +      - microtips,mf-101hiebcaf0
> > > +        # Microtips Technology MF-103HIEB0GA0 10.25" 1920x720 TFT LCD panel
> > > +      - microtips,mf-103hieb0ga0
> > >           # NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel
> > >         - nlt,nl192108ac18-02d
> > >