Re: [PATCH 0/8] selftests: x86: build suite with clang

From: Muhammad Usama Anjum
Date: Thu May 16 2024 - 10:07:39 EST


On 5/1/24 6:29 AM, Muhammad Usama Anjum wrote:
> This series fixes build errors found by clang to allow the x86 suite to
> get built with the clang.
>
> Unfortunately, there is one bug [1] in the clang becuase of which
> extended asm isn't handled correctly by it and build fails for
> sysret_rip.c. Hence even after this series the build of this test would
> fail with clang. Should we disable this test for now when clang is used
> until the bug is fixed in clang? Not sure. Any opinions?
Its seems like the bug has been fixed in clang. I'll verify it in next
release and draft a patch separately to fix that error.

I think this series is good to accept then.

>
> [1] https://github.com/llvm/llvm-project/issues/53728
>
> Muhammad Usama Anjum (8):
> selftests: x86: Remove dependence of headers file
> selftests: x86: check_initial_reg_state: remove -no-pie while using
> -static
> selftests: x86: test_vsyscall: remove unused function
> selftests: x86: fsgsbase_restore: fix asm directive from =rm to =r
> selftests: x86: syscall_arg_fault_32: remove unused variable
> selftests: x86: test_FISTTP: use fisttps instead of ambigous fisttp
> selftests: x86: fsgsbase: Remove unused function and variable
> selftests: x86: amx: Remove unused functions
>
> tools/testing/selftests/x86/Makefile | 9 +++++----
> tools/testing/selftests/x86/amx.c | 16 ----------------
> tools/testing/selftests/x86/fsgsbase.c | 6 ------
> tools/testing/selftests/x86/fsgsbase_restore.c | 2 +-
> tools/testing/selftests/x86/syscall_arg_fault.c | 1 -
> tools/testing/selftests/x86/test_FISTTP.c | 8 ++++----
> tools/testing/selftests/x86/test_vsyscall.c | 5 -----
> 7 files changed, 10 insertions(+), 37 deletions(-)
>

--
BR,
Muhammad Usama Anjum