Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'

[Dr. David Alan Gilbert]

* Frank Li (Frank.li@xxxxxxx) wrote:
> On Thu, May 16, 2024 at 02:32:11PM +0100, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > 
> > 'gpi_desc' seems like it was never used.
> > Remove it.
> 
> code change show 'reg_info', not 'gpi_desc'. You need make sure that it
> really is not used, not "seems like".

Oops that was a cut-and-paste when I did the commit on the name.

It was build tested.

V2 coming along now.

Dave

> 'struct reg_info' is never used, so remove it.
> 
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > ---
> >  drivers/dma/qcom/gpi.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index 1c93864e0e4d..639ab304db9b 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
> > @@ -476,12 +476,6 @@ struct gpi_dev {
> >  	struct gpii *gpiis;
> >  };
> >  
> > -struct reg_info {
> > -	char *name;
> > -	u32 offset;
> > -	u32 val;
> > -};
> > -
> >  struct gchan {
> >  	struct virt_dma_chan vc;
> >  	u32 chid;
> > -- 
> > 2.45.0
> > 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/