Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

[Shuah Khan]

On 5/16/24 10:21, Tejun Heo wrote:
> On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote:
> > On 5/13/24 11:02, Tejun Heo wrote:
> > > On Fri, May 10, 2024 at 12:06:25AM +0000, Edward Liaw wrote:
> > > > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> > > > redefinition warnings.
> > > >
> > > > Signed-off-by: Edward Liaw <edliaw@xxxxxxxxxx>
> > >
> > > Applied to cgroup/for-6.10.
> > >
> > > Thanks.
> >
> > Hi Tejun,
> >
> > Please don't include this in your PR to Linus. This patch series needs
> > to go together as it is causing several build warns and some errors.
>
> I'm afraid it's too late. The PR is too late. Do you want me to send an
> amended PR with the commit reverted? If it's just temporary issues in
> selftests, maybe we can just wait it out?

I am exploring options and leaning towards reverting the patch

daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE")

Your amending the PR helps me if I have to send revert. I am sorry
for the trouble.

I can all of them together in a second update or after the merge window
closes.

thanks,
-- Shuah