Re: [PATCH v3 1/2] dt-bindings: regulator: st,stm32mp1-pwr-reg: add compatible for STM32MP13

From: Patrick DELAUNAY
Date: Thu May 16 2024 - 12:33:55 EST


Hi,

On 5/15/24 18:15, Conor Dooley wrote:
On Wed, May 15, 2024 at 05:37:49PM +0200, Marek Vasut wrote:
On 5/15/24 5:35 PM, Conor Dooley wrote:
On Wed, May 15, 2024 at 04:33:22PM +0200, Patrick DELAUNAY wrote:
with

  compatible:
    oneOf:
        - items:
           - const: st,stm32mp1,pwr-reg
        - items:
           - const: st,stm32mp13-pwr-reg
           - const: st,stm32mp1,pwr-reg
Other than the extra ,s this looks okay, thanks.
I think the extra ,s are actually correct, those are the ones from the
original compatible which had TWO ,s (it does look a bit unusual).
Oh my bad then.


Ok, I prepare a V4 with fallback


and comma in compatible "st,stm32mp1,pwr-reg" was clearly an error

but it is too late to change it, see [1]

[1] ARM: st: use a correct pwr compatible for stm32mp15

https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=847733&state=*

regards

Patrick