Re: [PATCH RFC iwl-next 02/12] idpf: stop using macros for accessing queue descriptors

From: Mina Almasry
Date: Thu May 16 2024 - 13:52:01 EST


On Fri, May 10, 2024 at 8:28 AM Alexander Lobakin
<aleksander.lobakin@xxxxxxxxx> wrote:
>
> In C, we have structures and unions.
> Casting `void *` via macros is not only error-prone, but also looks
> confusing and awful in general.
> In preparation for splitting the queue structs, replace it with a
> union and direct array dereferences.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

FWIW,

Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx>

--
Thanks,
Mina