Re: [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE

From: Alexey Dobriyan
Date: Thu May 16 2024 - 15:10:56 EST


> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c

> -#undef _GNU_SOURCE
> -#define _GNU_SOURCE

No! Don't do this. It makes individual test program non-standalone.

Right now you can copy it to some other machine which triggers test
fauilure, compile and start debugging instead of remembering which
stupid compile flags it requires.

NAK for /proc, sorry. I'd like to keep #define.