Re: [PATCH v2 1/3] iomap: pass blocksize to iomap_truncate_page()

From: kernel test robot
Date: Thu May 16 2024 - 15:33:12 EST


Hi Zhang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on linus/master v6.9 next-20240516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Zhang-Yi/iomap-pass-blocksize-to-iomap_truncate_page/20240516-154238
base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/r/20240516073001.1066373-2-yi.zhang%40huaweicloud.com
patch subject: [PATCH v2 1/3] iomap: pass blocksize to iomap_truncate_page()
config: arm-davinci_all_defconfig (https://download.01.org/0day-ci/archive/20240517/202405170356.gLrF2NDl-lkp@xxxxxxxxx/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d3455f4ddd16811401fa153298fadd2f59f6914e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240517/202405170356.gLrF2NDl-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405170356.gLrF2NDl-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from fs/iomap/buffered-io.c:9:
In file included from include/linux/iomap.h:7:
In file included from include/linux/blk_types.h:10:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/arm/include/asm/cacheflush.h:10:
In file included from include/linux/mm.h:2210:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> fs/iomap/buffered-io.c:1453:7: warning: comparison of distinct pointer types ('typeof ((pos)) *' (aka 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
1453 | do_div(pos, blocksize);
| ^~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/div64.h:222:28: note: expanded from macro 'do_div'
222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
2 warnings generated.


vim +1453 fs/iomap/buffered-io.c

1446
1447 int
1448 iomap_truncate_page(struct inode *inode, loff_t pos, unsigned int blocksize,
1449 bool *did_zero, const struct iomap_ops *ops)
1450 {
1451 loff_t start = pos;
1452 unsigned int off = is_power_of_2(blocksize) ? (pos & (blocksize - 1)) :
> 1453 do_div(pos, blocksize);
1454
1455 /* Block boundary? Nothing to do */
1456 if (!off)
1457 return 0;
1458 return iomap_zero_range(inode, start, blocksize - off, did_zero, ops);
1459 }
1460 EXPORT_SYMBOL_GPL(iomap_truncate_page);
1461

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki