Re: [v1] wifi: mwifiex: Fix interface type change

From: Kalle Valo
Date: Fri May 17 2024 - 04:04:44 EST


Francesco Dolcini <francesco@xxxxxxxxxx> wrote:

> From: Rafael Beims <rafael.beims@xxxxxxxxxxx>
>
> When changing the interface type we also need to update the bss_num, the
> driver private data is searched based on a unique (bss_type, bss_num)
> tuple, therefore every time bss_type changes, bss_num must also change.
>
> This fixes for example an issue in which, after the mode changed, a
> wireless scan on the changed interface would not finish, leading to
> repeated -EBUSY messages to userspace when other scan requests were
> sent.
>
> Fixes: c606008b7062 ("mwifiex: Properly initialize private structure on interface type changes")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Rafael Beims <rafael.beims@xxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>

BTW I removed the Reviewed-by from the commit message, I don't see the need to
have both Reviewed-by and s-o-b.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20240510110458.15475-1-francesco@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches