Re: [v1] wifi: mwifiex: Fix interface type change

[Kalle Valo]

Francesco Dolcini <francesco@xxxxxxxxxx> writes:

> On Fri, May 17, 2024 at 08:04:24AM +0000, Kalle Valo wrote:
>
>> Francesco Dolcini <francesco@xxxxxxxxxx> wrote:
>> 
>> > From: Rafael Beims <rafael.beims@xxxxxxxxxxx>
>> > 
>> > When changing the interface type we also need to update the bss_num, the
>> > driver private data is searched based on a unique (bss_type, bss_num)
>> > tuple, therefore every time bss_type changes, bss_num must also change.
>> > 
>> > This fixes for example an issue in which, after the mode changed, a
>> > wireless scan on the changed interface would not finish, leading to
>> > repeated -EBUSY messages to userspace when other scan requests were
>> > sent.
>> > 
>> > Fixes: c606008b7062 ("mwifiex: Properly initialize private
>> > structure on interface type changes")
>> > Cc: stable@xxxxxxxxxxxxxxx
>> > Signed-off-by: Rafael Beims <rafael.beims@xxxxxxxxxxx>
>> > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>> 
>> BTW I removed the Reviewed-by from the commit message, I don't see the need to
>> have both Reviewed-by and s-o-b.
>
> Sure, I was in doubt about this, in the end I added it because I have seen
> this done in other subsystems, e.g. commit 6a4020b4c639 ("drm/bridge:
> tc358768: fix PLL parameters computation").

Heh, yeah we all do things a bit differently :) In my view s-o-b implies
that you have reviewed it as well but clearly not everyone think the
same. I'm fine either way, this is cosmetics anyway.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches