Re: [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card

[Naina Mehta]

On 5/17/2024 2:22 PM, Krzysztof Kozlowski wrote:
> On 16/05/2024 07:21, Naina Mehta wrote:
> > On 5/15/2024 7:53 PM, Krzysztof Kozlowski wrote:
> > > On 15/05/2024 14:09, Naina Mehta wrote:
> > > > Enable SDHCI on sdx75-idp to support SD card.
> > > > Also add the required regulators.
> > > >
> > > > Signed-off-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/qcom/sdx75-idp.dts | 45 ++++++++++++++++++++++++++
> > > >    1 file changed, 45 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
> > > > index f76e72fb2072..6f94278cf837 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
> > > > @@ -41,6 +41,29 @@
> > > >
> > > >    		vin-supply = <&vph_ext>;
> > > >    	};
> > > > +
> > > > +	vreg_sd_vccb: sd-vccb {
> > >
> > > Please use name for all fixed regulators which matches current format
> > > recommendation: 'regulator-[0-9]+v[0-9]+'
> >
> > Did you mean that vreg_sd_vdd should be updated according to the
> > suggested format because vreg_sd_vccb is not a fixed regulator?
>
> Yeah, it should be about sd-vdd, but then this one should be named as
> well with a similar prefix to have it consistent.

Sure, I will update in next revision.

Thanks,
Naina