Re: [PATCH] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()

From: Markus Elfring
Date: Fri May 17 2024 - 10:18:48 EST


> In tpmi_sst_dev_remove(), tpmi_sst is dereferenced after being freed. Fix this by reordering the kfree() post the dereference.

I suggest to take preferred line lengths better into account
also for such a change description.
Thus the second sentence should be put into a subsequent line.
How do you think about the following wording approach?

Move a kfree() call behind an assignment statement in the affected if branch.

Regards,
Markus