Re: clang: arch/x86/boot/printf.c:257:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

From: Nathan Chancellor
Date: Fri May 17 2024 - 11:00:31 EST


Hi Naresh,

On Fri, May 17, 2024 at 01:00:25PM +0200, Naresh Kamboju wrote:
> The following x86 build failed on Linux next-20240517 tag due to following
> warnings / errors only seen with clang builds.
>
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
>
> Build errors:
> ----
> arch/x86/boot/printf.c:257:3: error: unannotated fall-through between
> switch labels [-Werror,-Wimplicit-fallthrough]
> 257 | case 'u':
> | ^
> arch/x86/boot/printf.c:257:3: note: insert 'break;' to avoid fall-through
> 257 | case 'u':
> | ^
> | break;
> 1 error generated.
>
> The suspected patch,
> x86/boot: Add a fallthrough annotation

Thanks for the report, this has been addressed:

https://git.kernel.org/tip/82110ae235e0560d1f952f74f9fd991587b0e3a7

Cheers,
Nathan