Re: [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host

From: Krzysztof Wilczyński
Date: Fri May 17 2024 - 13:05:18 EST



Hello,

> This series is the continuation of previous work by Vidya Sagar [1] to fix the
> issues related to accessing DBI register space before completing the core
> initialization in some EP platforms like Tegra194/234 and Qcom EP.
>
> Since Vidya is busy, I took over the series based on his consent (off-list
> discussion).
>
> NOTE
> ====
>
> Based on the comments received in v7 [2], I've heavily modified the series
> to fix several other issues reported by Bjorn and Niklas. One noticeable
> change is getting rid of the 'core_init_notifer' flag added to differentiate
> between glue drivers requiring refclk from host and drivers getting refclk
> locally.
>
> By getting rid of this flag, now both the DWC EP driver and the EPF drivers
> can use a single flow and need not distinguish between the glue drivers.
>
> We can also get rid of the 'link_up_notifier' flag in the future by following
> the same convention.
>
> Testing
> =======
>
> I've tested the series on Qcom SM8450 based dev board that depends on refclk
> from host with EPF_MHI driver. It'd be good to test this series on platforms
> that generate refclk locally and also with EPF_TEST driver.

Applied to controller/dwc, thank you!

[01/08] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host
https://git.kernel.org/pci/pci/c/869bc5253406
[02/08] PCI: dwc: ep: Add Kernel-doc comments for APIs
https://git.kernel.org/pci/pci/c/7cbebc86c72a
[03/08] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops
https://git.kernel.org/pci/pci/c/b7dec6b85089
[04/08] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit()
https://git.kernel.org/pci/pci/c/c8682a3314c1
[05/08] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST#
https://git.kernel.org/pci/pci/c/570d7715eed8
[06/08] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers()
https://git.kernel.org/pci/pci/c/7d6e64c443ea
[07/08] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers
https://git.kernel.org/pci/pci/c/df69e17ccc2f
[08/08] PCI: endpoint: Remove "core_init_notifier" flag
https://git.kernel.org/pci/pci/c/a01e7214bef9

Krzysztof