Re: [PATCH 1/5] dt-bindings: mtd: gpmi-nand: Add 'fsl,imx8qxp-gpmi-nand' compatible string

[Frank Li]

On Fri, May 17, 2024 at 08:36:21PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.Li@xxxxxxx wrote on Fri, 17 May 2024 14:09:48 -0400:
> 
> > Add 'fsl,imx8qxp-gpmi-nand' compatible string and clock-names restriction.
> > 
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> >  .../devicetree/bindings/mtd/gpmi-nand.yaml         | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > index 021c0da0b072f..f9eb1868ca1f4 100644
> > --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > @@ -24,6 +24,7 @@ properties:
> >            - fsl,imx6q-gpmi-nand
> >            - fsl,imx6sx-gpmi-nand
> >            - fsl,imx7d-gpmi-nand
> > +          - fsl,imx8qxp-gpmi-nand
> >        - items:
> >            - enum:
> >                - fsl,imx8mm-gpmi-nand
> > @@ -151,6 +152,27 @@ allOf:
> >              - const: gpmi_io
> >              - const: gpmi_bch_apb
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - fsl,imx8qxp-gpmi-nand
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: SoC gpmi io clock
> > +            - description: SoC gpmi apb clock
> 
> I believe these two clocks are mandatory?

minItems default is equal to items numbers, here is 4. So all 4 clock are
mandatory.

Anything wrong here?

Frank

> 
> > +            - description: SoC gpmi bch clock
> > +            - description: SoC gpmi bch apb clock
> > +        clock-names:
> > +          items:
> > +            - const: gpmi_io
> > +            - const: gpmi_apb
> > +            - const: gpmi_bch
> > +            - const: gpmi_bch_apb
> > +
> >  examples:
> >    - |
> >      nand-controller@8000c000 {
> > 
> 
> 
> Thanks,
> Miquèl