Re: [RFC PATCH 0/9] reset: amlogic: move reset drivers out of CCF

From: Jan Dakinevich
Date: Fri May 17 2024 - 21:44:06 EST


This is a nice rework! But unfortunately after applying these patches at
least USB doesn't work on A1 SoC. My assumption it is because
RESET_MESON is now unselected due to dependency on AUXILIARY_BUS.

On 5/16/24 18:08, Jerome Brunet wrote:
> This RFC follows the discussion about having reset driver in the clock tree
> [1]. Ideally those should reside in the reset part of tree.
>
> Also the code of the amlogic reset driver is very similar between the 2 trees
> and could use the same driver code.
>
> This RFC moves the reset driver of audio clock controller of the g12 and
> sm1 SoC family to the reset tree, using the auxiliary bus.
>
> The infrastructure put in place is meant to be generic enough so we may
> eventually also move the reset drivers in the meson8b and aoclk clock
> controllers.
>
> [1] https://lore.kernel.org/linux-clk/e3a85852b911fdf16dd9ae158f42b3ef.sboyd@xxxxxxxxxx
>
> Jerome Brunet (9):
> reset: amlogic: convert driver to regmap
> reset: amlogic: add driver parameters
> reset: amlogic: split the device and platform probe
> reset: amlogic: use reset number instead of register count
> reset: amlogic: add reset status support
> reset: amlogic: add toggle reset support
> reset: amlogic: add auxiliary reset driver support
> clk: meson: add auxiliary reset helper driver
> clk: amlogic: axg-audio: use the auxiliary reset driver
>
> drivers/clk/meson/Kconfig | 6 +
> drivers/clk/meson/Makefile | 1 +
> drivers/clk/meson/axg-audio.c | 108 +--------
> drivers/clk/meson/meson-clk-rst-aux.c | 84 +++++++
> drivers/clk/meson/meson-clk-rst-aux.h | 14 ++
> drivers/reset/Kconfig | 1 +
> drivers/reset/reset-meson.c | 210 ++++++++++++++----
> include/soc/amlogic/meson8b-auxiliary-reset.h | 17 ++
> 8 files changed, 293 insertions(+), 148 deletions(-)
> create mode 100644 drivers/clk/meson/meson-clk-rst-aux.c
> create mode 100644 drivers/clk/meson/meson-clk-rst-aux.h
> create mode 100644 include/soc/amlogic/meson8b-auxiliary-reset.h
>

--
Best regards
Jan Dakinevich