Re: [PATCH 01/13] a2b: add A2B driver core

From: Markus Elfring
Date: Sun May 19 2024 - 07:19:28 EST



> +++ b/drivers/a2b/a2b.c
> @@ -0,0 +1,1252 @@

> +static int a2b_node_uevent(const struct device *dev,
> + struct kobj_uevent_env *env)
> +{

> + if (add_uevent_var(env, "A2B_NODE_VENDOR=%02x", node->vendor))
> + return -ENOMEM;

> + if (add_uevent_var(env, "A2B_NODE_VERSION=%02x", node->version))
> + return -ENOMEM;



I suggest to merge three if statements into one in a branch of
this function implementation.

Regards,
Markus