Re: [RFC PATCH net-next 23/28] net: ethernet: ti: cpsw-proxy-client: add sw tx/rx irq coalescing

From: Markus Elfring
Date: Sun May 19 2024 - 10:13:16 EST



> +++ b/drivers/net/ethernet/ti/cpsw-proxy-client.c

> @@ -996,8 +1001,15 @@ static int vport_tx_poll(struct napi_struct *napi_tx, int budget)

> + if (unlikely(tx_chn->tx_pace_timeout && !tdown)) {
> + hrtimer_start(&tx_chn->tx_hrtimer,
> + ns_to_ktime(tx_chn->tx_pace_timeout),
> + HRTIMER_MODE_REL_PINNED);
> + } else {
> + enable_irq(tx_chn->irq);
> + }

> @@ -1179,12 +1191,38 @@ static int vport_rx_poll(struct napi_struct *napi_rx, int budget)

> + if (unlikely(rx_chn->rx_pace_timeout)) {
> + hrtimer_start(&rx_chn->rx_hrtimer,
> + ns_to_ktime(rx_chn->rx_pace_timeout),
> + HRTIMER_MODE_REL_PINNED);
> + } else {
> + enable_irq(rx_chn->irq);
> + }


Would you like to omit curly brackets at a few source code places?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.9#n197

Regards,
Markus