Re: [PATCH net-next v2 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add clock support

[Krzysztof Kozlowski]

On 17/05/2024 07:47, Vineeth Karumanchi wrote:
> Add input clock support to gmii_to_rgmii IP.
> Add "clocks" bindings for the input clock.

Both sentences look like saying the same... confused.

> 
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> index 0f781dac6717..672bff6dae28 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> @@ -31,6 +31,9 @@ properties:
>    phy-handle:
>      $ref: ethernet-controller.yaml#/properties/phy-handle
>  
> +  clocks:
> +    description: 200/375 MHz free-running clock is used as input clock.

Missing constraints. Probably you wanted items above description.


Best regards,
Krzysztof