Re: [PATCH v1 3/3] spi: gpio: Make num_chipselect 8-bit in the struct spi_gpio_platform_data
From: Andy Shevchenko
Date: Mon May 20 2024 - 05:28:22 EST
On Fri, May 17, 2024 at 10:55:55PM +0100, Mark Brown wrote:
> On Fri, May 17, 2024 at 10:42:03PM +0300, Andy Shevchenko wrote:
> > There is no use for whole 16-bit for the number of chip select pins.
> > Drop it to 8 bits.
>
> because...?
To make the type stricter, but since there is no other benefits and
this one likely won't help to catch the (incorrect) use of big numbers
I think we don't need it.
> It's the only field in the struct so it's not like it makes
> any meaningful different to struct layout.
--
With Best Regards,
Andy Shevchenko