Re: [PATCH] livepatch: introduce klp_func called interface
From: zhang warden
Date: Mon May 20 2024 - 05:34:38 EST
OK, I will try to optimize my description after the patch is reviewed. I am sure there are something still need to be fix for that patch.
> On May 20, 2024, at 16:00, Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> Please add a version identifier to the message subject.
>
>
> …
>> If the patched function have bug, it may cause serious result
>> such as kernel crash.
>
> Wording suggestion:
>
> If the patched function has a bug, it might cause serious side effects
> like a kernel crash.
>
>
>> This is a kobject attribute of klp_func. Sysfs interface named
>> "called" is introduced to livepatch …
>
> Under which circumstances will imperative wordings be applied for
> another improved change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
>
>
> …
>> ---
>> include/linux/livepatch.h | 2 ++
> …
>
> You may present version descriptions behind the marker line.
> Would you like to indicate any adjustments according to your change approach
> (from yesterday)?
> https://lore.kernel.org/lkml/20240519074343.5833-1-zhangwarden@xxxxxxxxx/
>
> Regards,
> Markus