Re: [PATCH] kselftest/alsa: Ensure _GNU_SOURCE is defined

From: Shuah Khan
Date: Mon May 20 2024 - 10:24:10 EST


On 5/17/24 02:35, Takashi Iwai wrote:
On Thu, 16 May 2024 17:27:33 +0200,
Mark Brown wrote:

The pcmtest driver tests use the kselftest harness which requires that
_GNU_SOURCE is defined but nothing causes it to be defined. Since the
KHDR_INCLUDES Makefile variable has had the required define added let's
use that, this should provide some futureproofing.

Fixes: daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE")
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

The commit isn't yet in the Linus upstream tree but only in
linux-next. I guess it's better to put the fix in the tree (Shuah's?)
that introduced this change. So feel free to take my ack:

Acked-by: Takashi Iwai <tiwai@xxxxxxx>



Thank you. I will take this through my tree.

thanks,
-- Shuah