Re: [RFC PATCH 00/11] [RFC] Device / Driver and PCI Rust abstractions

From: Greg KH
Date: Mon May 20 2024 - 14:15:08 EST


On Mon, May 20, 2024 at 07:25:37PM +0200, Danilo Krummrich wrote:
> This patch sereis implements basic generic device / driver Rust abstractions,
> as well as some basic PCI abstractions.
>
> This patch series is sent in the context of [1], and the corresponding patch
> series [2], which contains some basic DRM Rust abstractions and a stub
> implementation of the Nova GPU driver.
>
> Nova is intended to be developed upstream, starting out with just a stub driver
> to lift some initial required infrastructure upstream. A more detailed
> explanation can be found in [1].
>
> Some patches, which implement the generic device / driver Rust abstractions have
> been sent a couple of weeks ago already [3]. For those patches the following
> changes have been made since then:
>
> - remove RawDevice::name()
> - remove rust helper for dev_name() and dev_get_drvdata()
> - use AlwaysRefCounted for struct Device
> - drop trait RawDevice entirely in favor of AsRef and provide
> Device::from_raw(), Device::as_raw() and Device::as_ref() instead
> - implement RevocableGuard
> - device::Data, remove resources and replace it with a Devres abstraction
> - implement Devres abstraction for resources
>
> As mentioned above, a driver serving as example on how these abstractions are
> used within a (DRM) driver can be found in [2].
>
> Additionally, the device / driver bits can also be found in [3], all
> abstractions required for Nova in [4] and Nova in [5].
>
> [1] https://lore.kernel.org/dri-devel/Zfsj0_tb-0-tNrJy@cassiopeiae/T/#u
> [2] https://lore.kernel.org/dri-devel/20240520172059.181256-1-dakr@xxxxxxxxxx/
> [3] https://github.com/Rust-for-Linux/linux/tree/staging/rust-device
> [4] https://github.com/Rust-for-Linux/linux/tree/staging/dev
> [5] https://gitlab.freedesktop.org/drm/nova/-/tree/nova-next
>
> Danilo Krummrich (2):
> rust: add abstraction for struct device
> rust: add devres abstraction
>
> FUJITA Tomonori (1):
> rust: add basic PCI driver abstractions
>
> Philipp Stanner (2):
> rust: add basic abstractions for iomem operations
> rust: PCI: add BAR request and ioremap
>
> Wedson Almeida Filho (6):
> rust: add driver abstraction
> rust: add rcu abstraction
> rust: add revocable mutex
> rust: add revocable objects
> rust: add device::Data
> rust: add `dev_*` print macros.

No list of the changes made since the last time this was submitted?

No versioning of this submission?

Why not?

thanks,

greg k-h