Re: [PATCH v2] ASoC: intel: Constify struct snd_soc_ops

From: Pierre-Louis Bossart
Date: Mon May 20 2024 - 17:33:35 EST




On 5/13/24 12:57, Christophe JAILLET wrote:
> Constifying "struct snd_soc_ops" moves some data to a read-only section, so
> increase overall security.
>
> This structure is also part of scripts/const_structs.checkpatch.
>
> As an example, on a x86_64, with allmodconfig:
> Before:
> text data bss dec hex filename
> 6315 3696 0 10011 271b sound/soc/intel/boards/ehl_rt5660.o
>
> After:
> text data bss dec hex filename
> 6379 3648 0 10027 272b sound/soc/intel/boards/ehl_rt5660.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested only.

We don't test all the boards in CI but I don't see any issues with
https://github.com/thesofproject/linux/pull/4993, so

Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>