Re: [PATCH v2 2/6] drm/ci: generate testlist from build

[Vignesh Raman]

Hi Helen,

On 21/05/24 01:54, Helen Koike wrote:
> On 17/05/2024 06:24, Vignesh Raman wrote:
> > Stop vendoring the testlist into the kernel. Instead, use the
> > testlist from the IGT build to ensure we do not miss renamed
> > or newly added tests.
> >
> > Signed-off-by: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>
> > ---
> >
> > v2:
> >    - Fix testlist generation for arm and arm64 builds.
> >
> > ---
> >   drivers/gpu/drm/ci/build-igt.sh  |   34 +
> >   drivers/gpu/drm/ci/igt_runner.sh |    9 +-
> >   drivers/gpu/drm/ci/testlist.txt  | 2761 ------------------------------
> >   3 files changed, 39 insertions(+), 2765 deletions(-)
> >   delete mode 100644 drivers/gpu/drm/ci/testlist.txt
> >
> > diff --git a/drivers/gpu/drm/ci/build-igt.sh 
> > b/drivers/gpu/drm/ci/build-igt.sh
> > index 7859554756c4..e62244728613 100644
> > --- a/drivers/gpu/drm/ci/build-igt.sh
> > +++ b/drivers/gpu/drm/ci/build-igt.sh
> > @@ -3,6 +3,30 @@
> >   set -ex
> > +function generate_testlist {
> > +    set +x
> > +    while read -r line; do
> > +        if [ "$line" = "TESTLIST" ] || [ "$line" = "END TESTLIST" ]; 
> > then
> > +            continue
> > +        fi
> > +
> > +        tests=$(echo "$line" | tr ' ' '\n')
> > +
> > +        for test in $tests; do
> > +            output=$(/igt/libexec/igt-gpu-tools/"$test" 
> > --list-subtests || true)
> > +
> > +            if [ -z "$output" ]; then
> > +                echo "$test"
> > +            else
> > +                echo "$output" | while read -r subtest; do
> > +                    echo "$test@$subtest"
> > +                done
> > +            fi
> > +        done
> > +    done < /igt/libexec/igt-gpu-tools/test-list.txt > 
> > /igt/libexec/igt-gpu-tools/testlist.txt
>
> Just a nit, could you rename the file to ci-testlist.txt ? Since 
> test-list.txt and testlist.txt can be easily confused.

Sure, will rename it. I missed to add the generating testlist print also.

Regards,
Vignesh

> Regards,
> Helen