Re: [PATCH 11/13] dt-bindings: a2b: add compatible string for Beosound Shape node

[Alvin Šipraga]

On Sun, May 19, 2024 at 01:41:48PM GMT, Krzysztof Kozlowski wrote:
> On 17/05/2024 15:02, Alvin Šipraga wrote:
> > From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> > 
> > The Beosound Shape has the same device tree bindings as an AD2425, so it
> > is sufficient to just add an entry to the compatible enum.
> 
> ? If it has the same, then devices are compatible but your binding did
> not express it.

OK, you're basically saying I should add it all in one patch?

> 
> > 
> > Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml b/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> > index dcda15e8032a..bea29f88d535 100644
> > --- a/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> > +++ b/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> > @@ -81,6 +81,7 @@ patternProperties:
> >            - adi,ad2427-node
> >            - adi,ad2428-node
> >            - adi,ad2429-node
> > +          - beo,shape-node
> 
> You just added this binding. Add entire binding in one patch.

i.e. this?

Thanks