Re: [PATCH v3 3/3] mm: Use update_mmu_tlb_range() to simplify code

[David Hildenbrand]

On 18.05.24 09:49, Bang Li wrote:
> Let us simplify the code by update_mmu_tlb_range().
>
> Signed-off-by: Bang Li <libang.li@xxxxxxxxxxxx>
> ---
>   mm/memory.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index eea6e4984eae..2d53e29cf76e 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -4421,7 +4421,6 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>   	vm_fault_t ret = 0;
>   	int nr_pages = 1;
>   	pte_t entry;
> -	int i;
>   
>   	/* File mapping without ->vm_ops ? */
>   	if (vma->vm_flags & VM_SHARED)
> @@ -4491,8 +4490,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>   		update_mmu_tlb(vma, addr, vmf->pte);
>   		goto release;
>   	} else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) {
> -		for (i = 0; i < nr_pages; i++)
> -			update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i);
> +		update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages);
>   		goto release;
>   	}
>   

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb