Re: [PATCH v6 16/49] x86/platform/intel-mid: Switch to new Intel CPU model defines
From: Andy Shevchenko
Date: Tue May 21 2024 - 10:12:22 EST
On Mon, May 20, 2024 at 03:45:47PM -0700, Tony Luck wrote:
> New CPU #defines encode vendor and family as well as model.
..
> - switch (boot_cpu_data.x86_model) {
> - case 0x3C:
> - case 0x4A:
> + switch (boot_cpu_data.x86_vfm) {
> + case INTEL_HASWELL:
Thanks, God^W your series, I just realised that this is quite a mistake.
I mean, you need to remove this line (with HASWELL) from this file.
Fixes: bc20aa48bbb3 ("x86, intel-mid: Add Merrifield platform support")
HASWELL was never a part of Intel MID initiative (in a sense how it's
organised in HW and FW).
> + case INTEL_ATOM_SILVERMONT_MID:
> x86_platform.legacy.rtc = 1;
> break;
So, TL;DR: Please add the patch, I will give a tag to it immediately.
--
With Best Regards,
Andy Shevchenko