Re: [PATCH v8-RESEND 05/33] dyndbg: replace classmap list with a vector

From: jim . cromie
Date: Tue May 21 2024 - 10:45:08 EST


On Tue, May 21, 2024 at 5:45 AM Łukasz Bartosik <ukaszb@xxxxxxxxxxxx> wrote:
>
> On Thu, May 16, 2024 at 7:44 PM Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
> >
> > Classmaps are stored in an elf section/array, but are individually
> > list-linked onto dyndbg's per-module ddebug_table for operation.
> >
> > This is unnecessary; even when ddebug_attach_classmap() is handling
> > the builtin section (with classmaps for multiple builtin modules), its
> > contents are ordered, so a module's possibly multiple classmaps will
> > be consecutive in the section, and could be treated as a vector/block,
> > since both start-addy and subrange length are in the ddebug_info arg.
>
> Should it be start-addr instead of start-addy ?
>

yes, we dont need spurious new terms. will fix.

> >
> > IOW, this treats classmaps similarly to _ddebugs, which are already
> > kept as vector-refs (address+len).