Re: [PATCH V2] PCI: Extend ACS configurability
From: kernel test robot
Date: Tue May 21 2024 - 11:46:40 EST
Hi Vidya,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.9 next-20240521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/PCI-Extend-ACS-configurability/20240521-191317
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240521110925.3876786-1-vidyas%40nvidia.com
patch subject: [PATCH V2] PCI: Extend ACS configurability
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240521/202405212300.S6fsze09-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240521/202405212300.S6fsze09-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405212300.S6fsze09-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/pci/pci.c:1044: warning: Function parameter or struct member 'caps' not described in 'pci_std_enable_acs'
vim +1044 drivers/pci/pci.c
cbe420361f92a31 Rajat Jain 2020-07-07 1038
cbe420361f92a31 Rajat Jain 2020-07-07 1039 /**
cbe420361f92a31 Rajat Jain 2020-07-07 1040 * pci_std_enable_acs - enable ACS on devices using standard ACS capabilities
cbe420361f92a31 Rajat Jain 2020-07-07 1041 * @dev: the PCI device
cbe420361f92a31 Rajat Jain 2020-07-07 1042 */
a0bcc944f0e307a Vidya Sagar 2024-05-21 1043 static void pci_std_enable_acs(struct pci_dev *dev, struct pci_acs *caps)
cbe420361f92a31 Rajat Jain 2020-07-07 @1044 {
cbe420361f92a31 Rajat Jain 2020-07-07 1045 /* Source Validation */
a0bcc944f0e307a Vidya Sagar 2024-05-21 1046 caps->ctrl |= (caps->cap & PCI_ACS_SV);
cbe420361f92a31 Rajat Jain 2020-07-07 1047
cbe420361f92a31 Rajat Jain 2020-07-07 1048 /* P2P Request Redirect */
a0bcc944f0e307a Vidya Sagar 2024-05-21 1049 caps->ctrl |= (caps->cap & PCI_ACS_RR);
cbe420361f92a31 Rajat Jain 2020-07-07 1050
cbe420361f92a31 Rajat Jain 2020-07-07 1051 /* P2P Completion Redirect */
a0bcc944f0e307a Vidya Sagar 2024-05-21 1052 caps->ctrl |= (caps->cap & PCI_ACS_CR);
cbe420361f92a31 Rajat Jain 2020-07-07 1053
cbe420361f92a31 Rajat Jain 2020-07-07 1054 /* Upstream Forwarding */
a0bcc944f0e307a Vidya Sagar 2024-05-21 1055 caps->ctrl |= (caps->cap & PCI_ACS_UF);
cbe420361f92a31 Rajat Jain 2020-07-07 1056
7cae7849fccee81 Alex Williamson 2021-06-18 1057 /* Enable Translation Blocking for external devices and noats */
7cae7849fccee81 Alex Williamson 2021-06-18 1058 if (pci_ats_disabled() || dev->external_facing || dev->untrusted)
a0bcc944f0e307a Vidya Sagar 2024-05-21 1059 caps->ctrl |= (caps->cap & PCI_ACS_TB);
cbe420361f92a31 Rajat Jain 2020-07-07 1060 }
cbe420361f92a31 Rajat Jain 2020-07-07 1061
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki