Re: [PATCH v1] perf top: Make zeroing histogram on refresh the default

[Arnaldo Carvalho de Melo]

On Fri, May 17, 2024 at 06:25:16PM -0700, Namhyung Kim wrote:
> On Thu, May 16, 2024 at 3:22 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > Instead of decaying histograms over time change it so that they are
> > zero-ed on each perf top refresh. Previously the option '-z', or
> > pressing 'z' in tui mode, would enable this behavior. Decaying samples
> > is non-intuitive as it isn't how "top" works. Make zeroing on refresh
> > the default and rename the command line options from 'z' to 'Z' and
> > 'zero' to 'decay'.
 
> While it may make more sense, I'm afraid of changing the default
> behavior.  I think we can add a config option for this.
 
> Also instead of adding a new option, it should be able to use the
> existing --no-zero option.

Hi Ingo,

	What do you think? -z and the default to decaying is in 'perf
top' since the very beginning, when it was called kerneltop:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e0143bad9dbf2a8fad4c5430562bceba196b66ea

Cheers,

- Arnaldo