Re: [PATCH v2 4/6] KEYS: trusted: Move tpm2_key_decode() to the TPM driver

From: David Howells
Date: Tue May 21 2024 - 17:44:31 EST


Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:

> On Tue May 21, 2024 at 9:18 PM EEST, James Bottomley wrote:
> ...
> You don't save a single byte of memory with any constant that dictates
> the size requirements for multiple modules in two disjoint subsystems.

I think James is just suggesting you replace your limit argument with a
constant not that you always allocate that amount of memory. What the limit
should be, OTOH, is up for discussion, but PAGE_SIZE seems not unreasonable.

David