Re: [PATCH net] net: ti: icssg_prueth: Fix NULL pointer dereference in prueth_probe()

From: MD Danish Anwar
Date: Wed May 22 2024 - 01:51:45 EST




On 21/05/24 6:14 pm, Romain Gantois wrote:
> In the prueth_probe() function, if one of the calls to emac_phy_connect()
> fails due to of_phy_connect() returning NULL, then the subsequent call to
> phy_attached_info() will dereference a NULL pointer.
>
> Check the return code of emac_phy_connect and fail cleanly if there is an
> error.
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>

Reviewed-by: MD Danish Anwar <danishanwar@xxxxxx>


--
Thanks and Regards,
Danish