Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters

From: Baolin Wang
Date: Wed May 22 2024 - 05:39:22 EST




On 2024/5/22 16:58, David Hildenbrand wrote:
On 22.05.24 10:51, Baolin Wang wrote:
The mTHP swap related counters: 'anon_swpout' and 'anon_swpout_fallback' are
confusing with an 'anon_' prefix, since the shmem can swap out non-anonymous
pages. So drop the 'anon_' prefix to keep consistent with the old swap counter
names.

Suggested-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
---

Am I daydreaming or did we add the anon_ for a reason and discussed the interaction with shmem? At least I remember some discussion around that.

Do you mean the shmem mTHP allocation counters in previous discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can not find previous discussions that provided a reason for adding the ‘anon_’ prefix. Barry, any comments? Thanks.

[1] https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@xxxxxxxxxxxxxxxxx/