Re: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics

From: Roland Xu
Date: Wed May 22 2024 - 11:55:14 EST


Fixes these in the v2 patch, thanks!

Greg KH:
> Can you wrap your lines at 72 columns like checkpatch asks for?

Greg KH:
> Please don't point to external sites for "more information", include it
here in the changelog text as this is where it is going to live for
"forever", random external sites hosted by others usually have short
lifespans.

________________________________________
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Sent: Wednesday, May 22, 2024 22:47
To: Roland Xu
Cc: ojeda@xxxxxxxxxx; boqun.feng@xxxxxxxxx; rust-for-linux@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics

On Wed, May 22, 2024 at 09:16:33PM +0800, Roland Xu wrote:
> Make the impl_has_work macro compatible with more complex generics such as lifetimes and const generic arguments.

Can you wrap your lines at 72 columns like checkpatch asks for?

> See more in https://github.com/Rust-for-Linux/linux/issues/1077

Please don't point to external sites for "more information", include it
here in the changelog text as this is where it is going to live for
"forever", random external sites hosted by others usually have short
lifespans.

thanks,

greg k-h