Re: [PATCH v5 00/68] Define _GNU_SOURCE for sources using

From: Shuah Khan
Date: Wed May 22 2024 - 12:35:20 EST


On 5/22/24 01:42, Paolo Abeni wrote:
On Wed, 2024-05-22 at 00:56 +0000, Edward Liaw wrote:
Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes
redefinitions of _GNU_SOURCE from source code.

809216233555 ("selftests/harness: remove use of LINE_MAX") introduced
asprintf into kselftest_harness.h, which is a GNU extension and needs
_GNU_SOURCE to either be defined prior to including headers or with the
-D_GNU_SOURCE flag passed to the compiler.

I'm sorry for the late question, but what is the merge plan here?



I have asked Edward Liaw explore options to localize the fix to the
problem introduced by the following commit

809216233555 ("selftests/harness: remove use of LINE_MAX")

I am not happy with the churn. I don't plan to merge this series
as it for sure.

If and when this problem gets fixed, I plan to merge the change and
take it through kselftest.

thanks,
-- Shuah