Re: [PATCH] spmi: pmic-arb: Pass the correct of_node to irq_domain_add_tree

[Konrad Dybcio]

On 5/22/24 14:06, Dmitry Baryshkov wrote:
> On Wed, 22 May 2024 at 14:38, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
> > Currently, irqchips for all of the subnodes (which represent a given
> > bus master) point to the parent wrapper node. This is no bueno, as
> > no interrupts arrive, ever (because nothing references that node).
> >
> > Fix that by passing a reference to the respective master's of_node.
> >
> > Worth noting, this is a NOP for devices with only a single master
> > described.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > ---
> >   drivers/spmi/spmi-pmic-arb.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> > index 791cdc160c51..46ea93f78dcd 100644
> > --- a/drivers/spmi/spmi-pmic-arb.c
> > +++ b/drivers/spmi/spmi-pmic-arb.c
> > @@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
> >
> >          dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);
> >
> > -       bus->domain = irq_domain_add_tree(dev->of_node,
> > -                                         &pmic_arb_irq_domain_ops, bus);
> > +       bus->domain = irq_domain_add_tree(node, pmic_arb_irq_domain_ops, bus);
>
> Shouldn't it be &pmic_arb_irq_domain_ops ?

Yes. Between testing and editing the patch to un-break the line I managed
to.. break the patch..

Konrad