Re: [PATCH] Input: ili210x - fix ili251x_read_touch_data() return value

From: Markus Elfring
Date: Wed May 22 2024 - 16:25:44 EST



> This fixes touch reporting when there are more than 6 active touches.

Does such information indicate a need for the tag “Fixes”?



> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -255,14 +255,15 @@ static int ili251x_read_reg(struct i2c_client *client,
> static int ili251x_read_touch_data(struct i2c_client *client, u8 *data)
> {
> int error;
> + int ret;
>
> error = ili251x_read_reg_common(client, REG_TOUCHDATA,
> data, ILI251X_DATA_SIZE1, 0);
> if (!error && data[0] == 2) {


I suggest to define the variable “ret” in the shown if branch.

Regards,
Markus