Re: [PATCH v3 4/5] mm/memory-failure: move hwpoison_filter() higher up

From: Oscar Salvador
Date: Wed May 22 2024 - 16:50:47 EST


On Tue, May 21, 2024 at 05:54:28PM -0600, Jane Chu wrote:
> Move hwpoison_filter() higher up as there is no need to spend a lot
> cycles only to find out later that the page is supposed to be skipped
> from hwpoison handling.
>
> Signed-off-by: Jane Chu <jane.chu@xxxxxxxxxx>

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

I was about to raise the point that prior to this change hwpoison_filter()
would be called after shake_folio(), which should turn some pages LRU, but
I see that shake_page() is also called in hwpoison-inject code.



--
Oscar Salvador
SUSE Labs