Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API

[Alexey Makhalov]

Hi Simon, apologize for long delay

On 5/11/24 8:02 AM, Simon Horman wrote:
> > diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h
>
> ...
>
> > +static inline
> > +unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1,
> > +				uint32_t *out1, uint32_t *out2)
>
> nit: u32 is preferred over uint32_t.
>       Likewise elsewhere in this patch-set.
Good to know. Can you please shed a light on the reason?
I still see bunch of stdint style uint32_t in arch/x86.


> ...
>
> >   /*
> > - * The high bandwidth in call. The low word of edx is presumed to have the
> > - * HB bit set.
> > + * High bandwidth calls are not supported on encrypted memory guests.
> > + * The caller should check cc_platform_has(CC_ATTR_MEM_ENCRYPT) and use
> > + * low bandwidth hypercall it memory encryption is set.
> > + * This assumption simplifies HB hypercall impementation to just I/O port
>
> nit: implementation
>
>       checkpatch.pl --codespell is your friend
Thanks, that is useful!

> > + * based approach without alternative patching.
> >    */
>
> ...