Re: [PATCH] utsname: constify ctl_table arguments of utility function

From: Joel Granados
Date: Thu May 23 2024 - 04:23:48 EST


On Sat, May 18, 2024 at 03:53:40PM +0200, Thomas Weißschuh wrote:
> The sysctl core is preparing to only expose instances of
...
>
> Cc: Joel Granados <j.granados@xxxxxxxxxxx>
> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> ---
> kernel/utsname_sysctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c
> index 76a772072557..04e4513f2985 100644
> --- a/kernel/utsname_sysctl.c
> +++ b/kernel/utsname_sysctl.c
> @@ -15,7 +15,7 @@
>
> #ifdef CONFIG_PROC_SYSCTL
>
> -static void *get_uts(struct ctl_table *table)
> +static void *get_uts(const struct ctl_table *table)
> {
> char *which = table->data;
> struct uts_namespace *uts_ns;
>
> ---
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> change-id: 20240518-sysctl-const-handler-utsname-3f3eec4e6dc3
>
> Best regards,
> --
> Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>

LGTM.

I'll bring this in through the sysctl tree for the next release; unless
folks want it to go in another way. For now it will go to sysctl-testing
waiting for the merge window to be closed.

Reviewed-by: Joel Granados <j.granados@xxxxxxxxxxx>

--

Joel Granados

Attachment: signature.asc
Description: PGP signature