Re: [PATCH v14 11/28] drm/connector: hdmi: Calculate TMDS character rate

From: Dmitry Baryshkov
Date: Thu May 23 2024 - 05:40:02 EST


On Tue, May 21, 2024 at 12:13:44PM +0200, Maxime Ripard wrote:
> Most HDMI drivers have some code to calculate the TMDS character rate,
> usually to adjust an internal clock to match what the mode requires.
>
> Since the TMDS character rates mostly depends on the resolution, whether
> we need to repeat pixels or not, the bpc count and the format, we can
> now derive it from the HDMI connector state that stores all those infos
> and remove the duplication from drivers.
>
> Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> ---
> drivers/gpu/drm/display/drm_hdmi_state_helper.c | 67 ++++++++++++++++++++++
> drivers/gpu/drm/drm_atomic.c | 1 +
> drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 +
> include/drm/drm_connector.h | 5 ++
> 4 files changed, 76 insertions(+)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry