Re: [PATCH] Bluetooth/nokia: Remove unused struct 'hci_nokia_radio_hdr'

From: Dr. David Alan Gilbert
Date: Thu May 23 2024 - 11:08:45 EST


* linux@xxxxxxxxxxx (linux@xxxxxxxxxxx) wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'hci_nokia_radio_hdr' looks like it was unused since it's
> initial commit.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Ping?
I see a message from the bot asking for a change to the header
which I think wants Bluetooth: nokia: ?
(But then a load of segfaults in the test scripts).

Anything else?

Dave

> ---
> drivers/bluetooth/hci_nokia.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
> index 97da0b2bfd17e..62633d9ba7c43 100644
> --- a/drivers/bluetooth/hci_nokia.c
> +++ b/drivers/bluetooth/hci_nokia.c
> @@ -116,11 +116,6 @@ struct hci_nokia_neg_evt {
> #define SETUP_BAUD_RATE 921600
> #define INIT_BAUD_RATE 120000
>
> -struct hci_nokia_radio_hdr {
> - u8 evt;
> - u8 dlen;
> -} __packed;
> -
> struct nokia_bt_dev {
> struct hci_uart hu;
> struct serdev_device *serdev;
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/