RE: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type

From: Luck, Tony
Date: Thu May 23 2024 - 12:03:01 EST


>> A single call to einj_get_available_error_type in init function is
>> sufficient to save the return value in a global variable to be used
>> later in various places in the code. This commit does not introduce
>> any functional changes, but only removing unnecessary redundant
>> function calls.
>>
>> Signed-off-by: Zaid Alali <zaidal@xxxxxxxxxxxxxxxxxxxxxx>
>
> Seems reasonable to me.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Agreed. I've thought about making this change many times, but always
distracted by other issues. Thanks for doing this.

Acked-by: Tony Luck <tony.luck@xxxxxxxxx>

-Tony