Re: [PATCH] dt-bindings: iio: adc: add a7779 doc

From: Jonathan Cameron
Date: Thu May 23 2024 - 13:04:17 EST


On Wed, 22 May 2024 15:33:56 +0200
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
Typo in the patch title.. dt-bindings: iio: adc: add ad7779

> On 22/05/2024 14:01, ranechita wrote:
> > Add dt bindings for adc ad7779.

Good to provide a very brief intro here to the device.
> >
> > Signed-off-by: ranechita <ramona.nechita@xxxxxxxxxx>
>
> Are you sure that's the name or identity you want to use? Looks like
> misconfigured git...
>
> > ---
> > .../ABI/testing/sysfs-bus-iio-adc-ad777x | 23 +++++
> > .../bindings/iio/adc/adi,ad7779.yaml | 93 +++++++++++++++++++
>
> Where is any user of it?
> ...
>
> > +
> > + clock-names:
> > + items:
> > + - const: adc-clk
>
> Drop names, it repeats what's obvious.
>
>
> Best regards,
> Krzysztof
>
>