Re: [PATCH] mm/filemap: invalidating pages is still necessary when io with IOCB_NOWAIT

From: Andrew Morton
Date: Thu May 23 2024 - 16:08:15 EST


On Mon, 13 May 2024 21:23:39 +0800 Liu Wei <liuwei09@xxxxxxxx> wrote:

> After commit (6be96d3ad3 fs: return if direct I/O will trigger writeback),
> when we issuing AIO with direct I/O and IOCB_NOWAIT on a block device, the
> process context will not be blocked.
>
> However, if the device already has page cache in memory, EAGAIN will be
> returned. And even when trying to reissue the AIO with direct I/O and
> IOCB_NOWAIT again, we consistently receive EAGAIN.
>
> Maybe a better way to deal with it: filemap_fdatawrite_range dirty pages
> with WB_SYNC_NONE flag, and invalidate_mapping_pages unmapped pages at
> the same time.

Can't userspace do this? If EAGAIN, sync the fd and retry the IO?