RE: [PATCH v2 3/5] dt-bindings: iio: dac: Add adi,ltc2664.yaml

[Paller, Kim Seer]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Thursday, May 23, 2024 2:40 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; David Lechner
> <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Liam
> Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <noname.nuno@xxxxxxxxx>
> Subject: Re: [PATCH v2 3/5] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> 
> [External]
> 
> On 23/05/2024 05:19, Kim Seer Paller wrote:
> > Add documentation for ltc2664.
> >
> 
> 
> > +
> > +  ref-supply:
> > +    description:
> > +      Reference Input/Output. The voltage at the REF pin sets the full-scale
> > +      range of all channels. If not provided the internal reference is used and
> > +      also provided on the VREF pin.
> > +
> > +  clr-gpios:
> > +    description:
> > +      Active-low Asynchronous Clear Input. A logic low at this level-triggered
> > +      input clears the part to the reset code and range determined by the
> > +      hardwired option chosen using the MSPAN pins. The control registers are
> > +      cleared to zero.
> 
> So this is a reset gpio?

Yes, this is a reset gpio.

Kim

> 
> > +    maxItems: 1
> > +
> > +  adi,manual-span-operation-config:
> > +    description:
> > +      This property must mimic the MSPAN pin configurations. By tying the
> MSPAN
> > +      pins (MSP2, MSP1 and MSP0) to GND and/or VCC, any output range can
> be
> > +      hardware-configured with different mid-scale or zero-scale reset options.
> > +      The hardware configuration is latched during power on reset for proper
> > +      operation.
> > +        0 - MPS2=GND, MPS1=GND, MSP0=GND
> > +        1 - MPS2=GND, MPS1=GND, MSP0=VCC
> > +        2 - MPS2=GND, MPS1=VCC, MSP0=GND
> > +        3 - MPS2=GND, MPS1=VCC, MSP0=VCC
> > +        4 - MPS2=VCC, MPS1=GND, MSP0=GND
> > +        5 - MPS2=VCC, MPS1=GND, MSP0=VCC
> > +        6 - MPS2=VCC, MPS1=VCC, MSP0=GND
> > +        7 - MPS2=VCC, MPS1=VCC, MSP0=VCC (enables SoftSpan feature)
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum: [0, 1, 2, 3, 4, 5, 6, 7]
> > +    default: 7
> > +
> > +  io-channels:
> > +    description:
> > +      Analog multiplexer output. VOUT0-VOUT3, MUXIN0-MUXIN3, REFLO,
> REF, V+, V-,
> 
> That's not output but input.
> 
> > +      and a temperature monitor output can be internally routed to the
> MUXOUT pin.
> 
> Needs maxItems
> 
> > +
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 0
> > +
> 
> 
> Best regards,
> Krzysztof