Re: [PATCH net] net: micrel: Fix lan8841_config_intr after getting out of sleep mode

[Horatiu Vultur]

The 05/23/2024 16:35, Suman Ghosh wrote:

Hi Suman,

> 
> >       if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> >               err = phy_read(phydev, LAN8814_INTS);
> >-              if (err)
> >+              if (err < 0)
> [Suman] Hi Horatiu,
> Should we modify this check for phy_write() as well?

I don't think we should modify this check for phy_write.
Because phy_write always return the error code. Which is negative or 0.

> >                       return err;
> >
> >               /* Enable / disable interrupts. It is OK to enable PTP
> >interrupt
> >--
> >2.34.1
> >
> 

-- 
/Horatiu