Re: [PATCH RFT 0/7] arm64: qcom: allow up to 4 lanes for the Type-C DisplayPort Altmode

[neil . armstrong]

On 24/05/2024 08:51, Luca Weiss wrote:
> On Thu May 23, 2024 at 11:06 AM CEST,  wrote:
> > Hi Lucas,
> >
> > On 10/05/2024 08:51, Luca Weiss wrote:
> > > On Tue Apr 23, 2024 at 4:08 PM CEST,  wrote:
> > > > On 23/04/2024 15:03, Konrad Dybcio wrote:
> > > > > On 4/5/24 12:19, Luca Weiss wrote:
> >
> > <snip>
> >
> > > Next, with DP 4 lane (not working on mainline but still plugged into a
> > > screen) the diff is quite a bit bigger.
> > >
> > > See attachments for the full files:
> > > * usb_1_qmpphy_20240503_151052_android_4lane.txt
> > > * usb_1_qmpphy_20240503_122443_mainline_4lane.txt
> > >
> > > Not attaching the diff because it's quite a lot
> > > $ diff --ignore-case -U0 usb_1_qmpphy_20240503_151052_android_4lane.txt usb_1_qmpphy_20240503_122443_mainline_4lane.txt
> > >
> > > Not sure this is helpful to anyone, but at least wanted to share what
> > > I've done so far here.
> >
> > Thanks a lot for the traces, it founds out the QPHY_V3_DP_COM_PHY_MODE_CTRL stays at 0x3,
> > which means the mode doesn't get broadcasted to the phy because.... the retimer only broadcasts
> > the orientation and not the mode... and it works on the HDKs and the X13s because they don't have retimers.
>
> Hi Neil,
>
> This was it!
>
> > So I made the changes in nb7vpq904m and ptn36502 drivers to get the next mux and broadcast the typec mode,
> > if you find time could you test it ?
> >
> > Bjorn could you also test on the rb3gen2 ?
> >
> > The changes:
> > https://git.codelinaro.org/neil.armstrong/linux/-/commit/a61fb3b816ecbe28a12480367d9e09b700ec09e1
>
> With this ptn36502 patch on top, I can confirm that DP 4-lane seems to
> work on qcm6490-fairphone-fp5 smartphone with DP over USB-C!
>
> Tested with a USB-C dongle that only has a HDMI port on the other side
> (so no USB), and cat'ing dp_debug while connected showed num_lanes = 4
>
> So feel free to add my:
>
> Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>

Thanks a lot for testing, spinning a v2 with those patches!

Neil

> Regards
> Luca
>
> > https://git.codelinaro.org/neil.armstrong/linux/-/commit/f6f976ff692bad430cd945f02b835e355f19632b
> >
> > Thanks,
> > Neil
> >
> > > Regards
> > > Luca
> > >
> > > > Neil
> > > >
> > > > > Konrad